changeset 595:a38cde48669f

Fixed memory leak in checkwait_smtpreply()
author mortenp
date Sat, 30 Sep 2006 06:08:20 +1000
parents 9d4d9beb8642
children aefc70519e62
files ChangeLog src/checkwait_smtpreply.c
diffstat 2 files changed, 12 insertions(+), 9 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Tue Sep 26 06:30:18 2006 +1000
+++ b/ChangeLog	Sat Sep 30 06:08:20 2006 +1000
@@ -1,5 +1,6 @@
+ o Fixed memory leak in checkwait_smtpreply()
  o Changed mlmmj-process to look at environment variable DEFAULT instead
-   of EXT for qmail.
+   of EXT for qmail (Fabio Busatto)
  o Added Frensh listtext unsub-confirm-digest (Christophe Gallienne)
 1.2.12-RC3
  o Fixed EOF handling in checkwait_smtpreply()
--- a/src/checkwait_smtpreply.c	Tue Sep 26 06:30:18 2006 +1000
+++ b/src/checkwait_smtpreply.c	Sat Sep 30 06:08:20 2006 +1000
@@ -47,39 +47,41 @@
 	switch(replytype) {
 		case MLMMJ_CONNECT:
 			if(smtpreply[0] != '2' || smtpreply[1] != '2')
-				return mystrdup(smtpreply);
+				return smtpreply;
 			break;
 		case MLMMJ_HELO:
 			if(smtpreply[0] != '2' || smtpreply[1] != '5')
-				return mystrdup(smtpreply);
+				return smtpreply;
 			break;
 		case MLMMJ_FROM:
 			if(smtpreply[0] != '2' || smtpreply[1] != '5')
-				return mystrdup(smtpreply);
+				return smtpreply;
 			break;
 		case MLMMJ_RCPTTO:
 			if(smtpreply[0] != '2' || smtpreply[1] != '5')
-				return mystrdup(smtpreply);
+				return smtpreply;
 			break;
 		case MLMMJ_DATA:
 			if(smtpreply[0] != '3' || smtpreply[1] != '5')
-				return mystrdup(smtpreply);
+				return smtpreply;
 			break;
 		case MLMMJ_DOT:
 			if(smtpreply[0] != '2' || smtpreply[1] != '5')
-				return mystrdup(smtpreply);
+				return smtpreply;
 			break;
 		case MLMMJ_QUIT:
 			if(smtpreply[0] != '2' || smtpreply[1] != '2')
-				return mystrdup(smtpreply);
+				return smtpreply;
 			break;
 		case MLMMJ_RSET:
 			if(smtpreply[0] != '2' || smtpreply[1] != '5')
-				return mystrdup(smtpreply);
+				return smtpreply;
 			break;
 		default:
 			break;
 	}
 
+	myfree(smtpreply);
+
 	return NULL;
 }