changeset 312:3b07f653af9d

execlp(..., 0) -> execlp(..., NULL)
author mmj
date Wed, 01 Sep 2004 18:47:18 +1000
parents f66ef77753cc
children 73f5c36ba79c
files ChangeLog src/listcontrol.c src/mlmmj-bounce.c src/mlmmj-maintd.c src/mlmmj-process.c src/mlmmj-recieve.c src/mlmmj-send.c src/mlmmj-sub.c src/mlmmj-unsub.c src/send_help.c
diffstat 10 files changed, 30 insertions(+), 28 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Wed Sep 01 18:22:49 2004 +1000
+++ b/ChangeLog	Wed Sep 01 18:47:18 2004 +1000
@@ -1,4 +1,6 @@
 1.0.0-RC3
+ o NULL and 0 are not the same on 64-bit platforms, so fix execlp(..., 0); to
+   be execlp(..., NULL);
  o Add web-interface (PHP). Thank you Christoph Thiel
  o Have the random numbers be somewhat longer everywhere and not just somewhere
  o Move free() to where it belongs fixing problems with mlmmj-process some
--- a/src/listcontrol.c	Wed Sep 01 18:22:49 2004 +1000
+++ b/src/listcontrol.c	Wed Sep 01 18:47:18 2004 +1000
@@ -148,7 +148,7 @@
 			execlp(mlmmjsub, mlmmjsub,
 					"-L", listdir,
 					"-a", fromemails->emaillist[0],
-					"-C", 0);
+					"-C", NULL);
 			log_error(LOG_ARGS, "execlp() of '%s' failed", mlmmjsub);
 			exit(EXIT_FAILURE);
 		} else /* Not a valid From: address, so we silently ignore */
@@ -168,7 +168,7 @@
 			execlp(mlmmjsub, mlmmjsub,
 					"-L", listdir,
 					"-a", tmpstr,
-					"-c", 0);
+					"-c", NULL);
 			log_error(LOG_ARGS, "execlp() of '%s' failed",
 					mlmmjsub);
 			exit(EXIT_FAILURE);
@@ -183,7 +183,7 @@
 			execlp(mlmmjunsub, mlmmjunsub,
 					"-L", listdir,
 					"-a", fromemails->emaillist[0],
-					"-C", 0);
+					"-C", NULL);
 			log_error(LOG_ARGS, "execlp() of '%s' failed",
 					mlmmjunsub);
 			exit(EXIT_FAILURE);
@@ -204,7 +204,7 @@
 			execlp(mlmmjunsub, mlmmjunsub,
 					"-L", listdir,
 					"-a", tmpstr,
-					"-c", 0);
+					"-c", NULL);
 			log_error(LOG_ARGS, "execlp() of '%s' failed",
 					mlmmjunsub);
 			exit(EXIT_FAILURE);
@@ -223,7 +223,7 @@
 				"-L", listdir,
 				"-a", param,
 				"-m", mailname,
-				"-n", bouncenr, 0);
+				"-n", bouncenr, NULL);
 		log_error(LOG_ARGS, "execlp() of '%s' failed", mlmmjbounce);
 		exit(EXIT_FAILURE);
 		break;
@@ -239,7 +239,7 @@
 		} else {
 			execlp(mlmmjsend, mlmmjsend,
 					"-L", listdir,
-					"-m", moderatefilename, 0);
+					"-m", moderatefilename, NULL);
 			log_error(LOG_ARGS, "execlp() of %s failed", mlmmjsend);
 			exit(EXIT_FAILURE);
 		}
@@ -272,7 +272,7 @@
 					"-L", listdir,
 					"-l", "6",
 					"-m", archivefilename,
-					"-a", "-D", 0);
+					"-a", "-D", NULL);
 		}
 		break;
 	}
--- a/src/mlmmj-bounce.c	Wed Sep 01 18:22:49 2004 +1000
+++ b/src/mlmmj-bounce.c	Wed Sep 01 18:47:18 2004 +1000
@@ -165,7 +165,7 @@
 				"-L", listdir,
 				"-T", myaddr,
 				"-F", from,
-				"-m", queuefilename, 0);
+				"-m", queuefilename, NULL);
 
 	log_error(LOG_ARGS, "execlp() of '%s' failed", mlmmjsend);
 
--- a/src/mlmmj-maintd.c	Wed Sep 01 18:22:49 2004 +1000
+++ b/src/mlmmj-maintd.c	Wed Sep 01 18:47:18 2004 +1000
@@ -333,14 +333,14 @@
 						"-F", from,
 						"-T", to,
 						"-R", repto,
-						"-a", 0);
+						"-a", NULL);
 			} else {
 				execlp(mlmmjsend, mlmmjsend,
 						"-l", "1",
 						"-m", mailname,
 						"-F", from,
 						"-T", to,
-						"-a", 0);
+						"-a", NULL);
 			}
 		}
 	}
@@ -447,7 +447,7 @@
 					"-m", archivefilename,
 					"-s", subnewname,
 					"-a",
-					"-D", 0);
+					"-D", NULL);
 		}
 	}
 
@@ -587,7 +587,7 @@
 			execlp(mlmmjbounce, mlmmjbounce,
 					"-L", listdir,
 					"-a", probefile,
-					"-p", 0);
+					"-p", NULL);
 			log_error(LOG_ARGS, "Could not execlp %s",
 						mlmmjbounce);
 			return 1;
@@ -716,7 +716,7 @@
 		} else {
 			execlp(mlmmjunsub, mlmmjunsub,
 					"-L", listdir,
-					"-a", address, 0);
+					"-a", address, NULL);
 			log_error(LOG_ARGS, "Could not execlp %s",
 						mlmmjunsub);
 			return 1;
--- a/src/mlmmj-process.c	Wed Sep 01 18:22:49 2004 +1000
+++ b/src/mlmmj-process.c	Wed Sep 01 18:47:18 2004 +1000
@@ -180,7 +180,7 @@
 				"-l", "2",
 				"-L", listdir,
 				"-F", from,
-				"-m", queuefilename, 0);
+				"-m", queuefilename, NULL);
 
 	log_error(LOG_ARGS, "execlp() of '%s' failed", mlmmjsend);
 
@@ -550,7 +550,7 @@
 					"-F", efromemails.emaillist[0],
 					"-s", owner,
 					"-a",
-					"-m", mailfile, 0);
+					"-m", mailfile, NULL);
 			log_error(LOG_ARGS, "execlp() of '%s' failed",
 					mlmmjsend);
 			exit(EXIT_FAILURE);
@@ -615,7 +615,7 @@
 				"-l", "1",
 				"-T", fromemails.emaillist[0],
 				"-F", fromaddr,
-				"-m", queuefilename, 0);
+				"-m", queuefilename, NULL);
 
 		log_error(LOG_ARGS, "execlp() of '%s' failed", mlmmjsend);
 		exit(EXIT_FAILURE);
@@ -650,7 +650,7 @@
 					"-l", "1",
 					"-T", fromemails.emaillist[0],
 					"-F", fromaddr,
-					"-m", queuefilename, 0);
+					"-m", queuefilename, NULL);
 
 			log_error(LOG_ARGS, "execlp() of '%s' failed", mlmmjsend);
 			exit(EXIT_FAILURE);
@@ -687,7 +687,7 @@
 					"-l", "1",
 					"-T", fromemails.emaillist[0],
 					"-F", fromaddr,
-					"-m", queuefilename, 0);
+					"-m", queuefilename, NULL);
 
 			log_error(LOG_ARGS, "execlp() of '%s' failed",
 					mlmmjsend);
@@ -723,7 +723,7 @@
 	
 	execlp(mlmmjsend, mlmmjsend,
 				"-L", listdir,
-				"-m", donemailname, 0);
+				"-m", donemailname, NULL);
 	log_error(LOG_ARGS, "execlp() of '%s' failed", mlmmjsend);
 
 	return EXIT_FAILURE;
--- a/src/mlmmj-recieve.c	Wed Sep 01 18:22:49 2004 +1000
+++ b/src/mlmmj-recieve.c	Wed Sep 01 18:47:18 2004 +1000
@@ -166,7 +166,7 @@
 
 	execlp(mlmmjprocess, mlmmjprocess,
 				"-L", listdir,
-				"-m", infilename, 0);
+				"-m", infilename, NULL);
 	log_error(LOG_ARGS, "execlp() of '%s' failed", mlmmjprocess);
 
 	exit(EXIT_FAILURE);
--- a/src/mlmmj-send.c	Wed Sep 01 18:22:49 2004 +1000
+++ b/src/mlmmj-send.c	Wed Sep 01 18:47:18 2004 +1000
@@ -159,7 +159,7 @@
 	execlp(mlmmjbounce, mlmmjbounce,
 			"-L", listdir,
 			"-a", addr,
-			"-n", num, 0);
+			"-n", num, NULL);
 
 	log_error(LOG_ARGS, "execlp() of '%s' failed", mlmmjbounce);
 
--- a/src/mlmmj-sub.c	Wed Sep 01 18:22:49 2004 +1000
+++ b/src/mlmmj-sub.c	Wed Sep 01 18:47:18 2004 +1000
@@ -118,7 +118,7 @@
 				"-l", "1",
 				"-T", subaddr,
 				"-F", fromaddr,
-				"-m", queuefilename, 0);
+				"-m", queuefilename, NULL);
 	log_error(LOG_ARGS, "execlp() of '%s' failed", mlmmjsend);
 	exit(EXIT_FAILURE);
 }
@@ -149,7 +149,7 @@
 			"-l", "1",
 			"-T", fromstr,
 			"-F", fromaddr,
-			"-m", queuefilename, 0);
+			"-m", queuefilename, NULL);
 
 	myfree(fromstr);
 
@@ -282,7 +282,7 @@
 				"-T", subaddr,
 				"-F", fromaddr,
 				"-R", confirmaddr,
-				"-m", queuefilename, 0);
+				"-m", queuefilename, NULL);
 	log_error(LOG_ARGS, "execlp() of '%s' failed", mlmmjsend);
 	exit(EXIT_FAILURE);
 }
--- a/src/mlmmj-unsub.c	Wed Sep 01 18:22:49 2004 +1000
+++ b/src/mlmmj-unsub.c	Wed Sep 01 18:47:18 2004 +1000
@@ -120,7 +120,7 @@
 				"-l", "1",
 				"-T", subaddr,
 				"-F", fromaddr,
-				"-m", queuefilename, 0);
+				"-m", queuefilename, NULL);
 	log_error(LOG_ARGS, "execlp() of '%s' failed", mlmmjsend);
 	exit(EXIT_FAILURE);
 }
@@ -151,7 +151,7 @@
                         "-l", "1",
                         "-T", fromstr,
                         "-F", fromaddr,
-                        "-m", queuefilename, 0);
+                        "-m", queuefilename, NULL);
 
         myfree(fromstr);
 
@@ -283,7 +283,7 @@
 				"-T", subaddr,
 				"-F", fromaddr,
 				"-R", confirmaddr,
-				"-m", queuefilename, 0);
+				"-m", queuefilename, NULL);
 	log_error(LOG_ARGS, "execlp() of '%s' failed", mlmmjsend);
 	exit(EXIT_FAILURE);
 }
--- a/src/send_help.c	Wed Sep 01 18:22:49 2004 +1000
+++ b/src/send_help.c	Wed Sep 01 18:47:18 2004 +1000
@@ -83,7 +83,7 @@
 				"-l", "1",
 				"-T", emailaddr,
 				"-F", fromaddr,
-				"-m", queuefilename, 0);
+				"-m", queuefilename, NULL);
 
 	log_error(LOG_ARGS, "execlp() of '%s' failed", mlmmjsend);
 	exit(EXIT_FAILURE);