Mercurial > hg > mlmmj

changeset 726:7d4efc26d03a

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Check return status in mlmmj-perl-admin when adding subscribers (Florian Streibelt, Bitmand)
author Ben Schmidt
date Fri, 30 Jul 2010 09:21:28 +1000
parents d92234debf5c
children 4575d3181ca1
files ChangeLog contrib/web/perl-admin/htdocs/subscribers.cgi
diffstat 2 files changed, 12 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Sun Jul 18 21:46:30 2010 +1000
+++ b/ChangeLog	Fri Jul 30 09:21:28 2010 +1000
@@ -1,3 +1,5 @@
+ o Check return status in mlmmj-perl-admin when adding subscribers (Florian
+   Streibelt, Bitmand)
  o Better validation of input in php-admin (Thomas Goirand)
  o Added Turkish translation (Samed Beyribey)
  o Fixed security bug in mlmmj-php-admin (Florian Streibelt, Morten Shearman
--- a/contrib/web/perl-admin/htdocs/subscribers.cgi	Sun Jul 18 21:46:30 2010 +1000
+++ b/contrib/web/perl-admin/htdocs/subscribers.cgi	Fri Jul 30 09:21:28 2010 +1000
@@ -104,8 +104,12 @@
 		if ($nomailsub) {
 			system "$mlmmjsub -L $topdir/$list -a $email -Un -s";
 		}
+		if ($? == 0) {
 		$action .= "$email has been subscribed.<br>\n";
 	   } else {
+			$action .= "error subscribing $email (code $?)<br>\n";
+		}
+	   } else {
 		$action .= '"'.encode_entities($email).'" is not a valid email address.<br>';
 	   }
 	}
@@ -123,7 +127,11 @@
 		if ($nomailsub) {
 			system "$mlmmjsub -L $topdir/$list -a $email -Un -s";
 		}
+		if ($? == 0) {
+			$action = "$email has been added";
+		} else {
 		$action = "error adding $email (code $?)";
+		}
 	} else {
 		$action = '"'.encode_entities($email).'" is not a valid email address.';
 	}