# HG changeset patch
# User Ben Schmidt
# Date 1290259869 -39600
# Node ID 284c640f1b3ff21753c2d9a8b2ca56b766c260bf
# Parent b542f6e55f5b0fdc4ab8f30731eb3c509a94d02b
Check return status in mlmmj-perl-admin when adding subscribers (Florian
Streibelt, Bitmand)
diff -r b542f6e55f5b -r 284c640f1b3f ChangeLog
--- a/ChangeLog Sun Nov 21 00:30:23 2010 +1100
+++ b/ChangeLog Sun Nov 21 00:31:09 2010 +1100
@@ -1,3 +1,5 @@
+ o Check return status in mlmmj-perl-admin when adding subscribers (Florian
+ Streibelt, Bitmand)
o Better validation of input in php-admin (Thomas Goirand)
o Added Turkish translation (Samed Beyribey)
o Fixed security bug in mlmmj-php-admin (Florian Streibelt, Morten Shearman
diff -r b542f6e55f5b -r 284c640f1b3f contrib/web/perl-admin/htdocs/subscribers.cgi
--- a/contrib/web/perl-admin/htdocs/subscribers.cgi Sun Nov 21 00:30:23 2010 +1100
+++ b/contrib/web/perl-admin/htdocs/subscribers.cgi Sun Nov 21 00:31:09 2010 +1100
@@ -104,8 +104,12 @@
if ($nomailsub) {
system "$mlmmjsub -L $topdir/$list -a $email -Un -s";
}
+ if ($? == 0) {
$action .= "$email has been subscribed.
\n";
} else {
+ $action .= "error subscribing $email (code $?)
\n";
+ }
+ } else {
$action .= '"'.encode_entities($email).'" is not a valid email address.
';
}
}
@@ -123,7 +127,11 @@
if ($nomailsub) {
system "$mlmmjsub -L $topdir/$list -a $email -Un -s";
}
+ if ($? == 0) {
+ $action = "$email has been added";
+ } else {
$action = "error adding $email (code $?)";
+ }
} else {
$action = '"'.encode_entities($email).'" is not a valid email address.';
}