report a bug |  advanced search |  statistics |  developer log in/out
Request #65 Add new option '-d' for mlmmj-make-ml to specify FQDN domain name
Submitted: 2017-08-27 08:48 UTC Modified: 2018-01-16 13:32 UTC
Votes:1
Avg. Score:5.0 ± 0.0
Reproduced:0 of 0 (0.0%)
From: zhb at iredmail dot org Assigned:
Status: Open
Mlmmj Version: 1.3.0.0 OS:
MTA: MTA Version:
View Add Comment Developer Edit
Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know!
Just going to say 'Me too!'? Don't clutter the database with that please — but make sure to vote on the bug!
Your email address:
MUST BE VALID
Solve the problem:
48 - 14 = ?
Subscribe to this entry?

 
 [2017-08-27 08:48 UTC] zhb at iredmail dot org
Description:
------------
This patch adds a new option '-d' for mlmmj-make-ml to specify FQDN domain name, so 
that we can create mailing list account without interactive (only '-d' is not enough, 
more tiny patches are coming).


Patches

mlmmj-make-ml-dol.patch (last revision 2018-01-16 17:21 UTC) by zhb at iredmail dot org)
mlmmj-make-ml-do.patch (last revision 2017-08-27 20:34 UTC) by zhb at iredmail dot org)
mlmmj-make-ml-d-man.patch (last revision 2017-08-27 17:30 UTC) by zhb at iredmail dot org)
mlmmj-make-ml-d.patch (last revision 2017-08-27 08:49 UTC) by zhb at iredmail dot org)

Add a Patch

History

AllCommentsChanges
 [2017-08-27 20:34 UTC] zhb at iredmail dot org
New patch with -d and -o options.

-d: The domain name part of the mailing list
-o: The email address of the list owner
 [2017-08-27 20:51 UTC] zhb at iredmail dot org
Latest patch with all 3 options support:

-d: The domain name part of the mailing list
-o: The email address of the list owner
-l: The language of list text template files
 [2018-01-16 13:26 UTC] maintainer at mlmmj dot org
This is a great patch!

I have just one concern with it. Changing the working directory used to be done inside a subshell so it didn't affect the working directory of the main script, but this has been changed by the patch.

This may be important in case relative paths are used on the commandline, etc., so could you please adjust this patch so the working directory change is isolated as it was before.

If any problems, let me know and we can seek a solution.
 [2018-01-16 13:32 UTC] maintainer at mlmmj dot org
O, also, the new options should be added to the top of the usage message where all the options are listed briefly. The [-z] there should be removed, too.
 [2018-01-16 17:23 UTC] zhb at iredmail dot org
Updated patch as requested: "Changing the working directory used to be done inside a 
subshell".

About the order of options, feel free to change it if don't like it.
 [2019-01-26 19:33 UTC] stappers at stappers dot nl
Applied.

https://gitlab.com/mlmmj/mlmmj/commit/e0d9aa7e45ba03cd066333ee5bd6a273412e619d
 
Based on the PHP bug tracker.
Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Wed Jan 30 01:27:44 2013 UTC